feat: rn layout hook #1662
Merged
feat: rn layout hook #1662
+128
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyuki
reviewed
Oct 17, 2024
| @@ -0,0 +1,31 @@ | |||
| import { TextStyle } from 'react-native' | |||
| import { Children, cloneElement } from 'react' | |||
hiyuki
reviewed
Oct 17, 2024
| textProps?: Record<string, any> | ||
| } | ||
|
|
||
| export function wrapChildren (props: Record<string, any> = {}, { hasVarDec, varContext }: WrapChildrenConfig, { textStyle, textProps } : TextConfig = {}) { |
There was a problem hiding this comment.
WrapChildrenConfig和TextConfig合成一个config就行
There was a problem hiding this comment.
mpx-view也可以调用这个方法，外部再去拼bgImage就可以，
hiyuki
reviewed
Oct 17, 2024
| }) | ||
| } | ||
| if (hasVarDec && varContext) { | ||
| children = <VarContext.Provider value={varContext}>{children}</VarContext.Provider> |
hiyuki
reviewed
Oct 17, 2024
| @@ -130,6 +130,16 @@ const useInnerProps = ( | |||
| const propsRef = useRef<Record<string, any>>({}) | |||
| const eventConfig: { [key: string]: string[] } = {} | |||
| const config = rawConfig || { layoutRef: { current: {} }, disableTouch: false, disableTap: false } | |||
| const removeProps = [ | |||
| 'enable-background', | |||
hiyuki
reviewed
Oct 17, 2024
| const hasLayoutRef = useRef(false) | ||
| const layoutStyle: Record<string, any> = hasLayoutRef.current ? {} : DEFAULT_UNLAY_STYLE | ||
| const layoutProps: Record<string, any> = {} | ||
| if (hasSelfPercent || onLayout) { |
There was a problem hiding this comment.
这里还要判断一个props['enable-offset']
hiyuki
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.